[checkout] Code generation: update services and models #1609
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a comprehensive update to the checkout service's code generation, incorporating new API capabilities and refining existing data models. The changes aim to expand the platform's functionality by introducing mechanisms for forwarding payment details, enabling advanced payment validations, and standardizing SDK-related data. These updates facilitate more flexible and robust payment processing, particularly for complex scenarios involving network tokens and enhanced scheme data, while also improving the clarity and accuracy of data model descriptions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant number of changes, primarily auto-generated from an OpenAPI specification update for the checkout service to version v71. The changes include adding new services, models, and properties, as well as updating existing ones. My review focused on the correctness and maintainability of these generated changes. I've identified a few minor issues, mainly related to documentation comments and a potential typo in a property name originating from the spec. Overall, the generated code seems correct and follows existing patterns.
| /** | ||
| * Base64-encoded JSON object containing SDK related parameters required by the SDK | ||
| */ | ||
| "sdkData"?: string; |
There was a problem hiding this comment.
The comment for sdkData is missing important information about not including sensitive data. This information was present on the sdkData property that was removed from PaymentRequest. It would be beneficial to include this warning for developers. This comment applies to all newly added sdkData properties across the different payment detail files in this PR.
| /** | |
| * Base64-encoded JSON object containing SDK related parameters required by the SDK | |
| */ | |
| "sdkData"?: string; | |
| /** | |
| * Base64-encoded JSON object containing SDK related parameters required by the SDK to function optimally. Clients must not add unrelated or sensitive personal information. | |
| */ | |
| "sdkData"?: string; |
| /** | ||
| * The date that the the shopper\'s bank account is charged. | ||
| */ | ||
| "sepadirectdebit_sepadirectdebit_dueDate"?: string; |
There was a problem hiding this comment.
The property name sepadirectdebit_sepadirectdebit_dueDate seems to have a duplicate sepadirectdebit. This is likely due to its baseName being sepadirectdebit.sepadirectdebit.dueDate in the attributeTypeMap, which also seems to contain a typo. This might be an issue in the underlying OpenAPI specification. If so, it should be corrected there to generate a cleaner property name like sepadirectdebit_dueDate.
| /** | ||
| * This is the `recurringDetailReference` returned in the response when you created the token. | ||
| */ | ||
| "storedPaymentMethodId"?: string; |
There was a problem hiding this comment.
The comment for storedPaymentMethodId incorrectly refers to recurringDetailReference. This seems to be a copy-paste error and should be corrected to refer to storedPaymentMethodId. This issue is present in many other payment detail files in this PR where storedPaymentMethodId is defined.
| /** | |
| * This is the `recurringDetailReference` returned in the response when you created the token. | |
| */ | |
| "storedPaymentMethodId"?: string; | |
| /** | |
| * This is the `storedPaymentMethodId` returned in the response when you created the token. | |
| */ | |
| "storedPaymentMethodId"?: string; |
AdyenAutomationBot
force-pushed
the
sdk-automation/checkout
branch
from
61c5cf7 to
37d5bd5
Compare
AdyenAutomationBot
force-pushed
the
sdk-automation/checkout
branch
from
37d5bd5 to
d4c37a5
Compare
This PR contains the automated changes for the
checkoutservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.